class Ameba::Rule::Performance::FirstLastAfterFilter

Overview

This rule is used to identify usage of first/last/first?/last? calls that follow filters.

For example, this is considered inefficient:

[-1, 0, 1, 2].select { |e| e > 0 }.first?
[-1, 0, 1, 2].select { |e| e > 0 }.last?

And can be written as this:

[-1, 0, 1, 2].find { |e| e > 0 }
[-1, 0, 1, 2].reverse_each.find { |e| e > 0 }

YAML configuration example:

Performance/FirstLastAfterFilter
  Enabled: true
  FilterNames:
    - select

Included Modules

Defined in:

ameba/rule/performance/first_last_after_filter.cr

Constant Summary

CALL_NAMES = ["first", "last", "first?", "last?"] of ::String
MSG = "Use `find {...}` instead of `%s {...}.%s`"
MSG_REVERSE = "Use `reverse_each.find {...}` instead of `%s {...}.%s`"

Constructors

Instance Method Summary

Instance methods inherited from class Ameba::Rule::Base

==(other) ==, catch(source : Source) catch, excluded?(source) excluded?, group group, hash hash, name name, special? special?, test(source : Source, node : Crystal::ASTNode, *opts)
test(source : Source) test

Class methods inherited from class Ameba::Rule::Base

parsed_doc parsed_doc

Macros inherited from class Ameba::Rule::Base

issue_for(*args) issue_for

Macros inherited from module Ameba::Config::RuleConfig

properties(&block) properties

Constructor Detail

def self.new(ctx : YAML::ParseContext, node : YAML::Nodes::Node) #

def self.new(config = nil) #

This rule is used to identify usage of first/last/first?/last? calls that follow filters.

For example, this is considered inefficient:

[-1, 0, 1, 2].select { |e| e > 0 }.first?
[-1, 0, 1, 2].select { |e| e > 0 }.last?

And can be written as this:

[-1, 0, 1, 2].find { |e| e > 0 }
[-1, 0, 1, 2].reverse_each.find { |e| e > 0 }

YAML configuration example:

Performance/FirstLastAfterFilter
  Enabled: true
  FilterNames:
    - select

[View source]
def self.new(*, __context_for_yaml_serializable ctx : YAML::ParseContext, __node_for_yaml_serializable node : YAML::Nodes::Node) #

Instance Method Detail

def description : String #

def description=(description : String) #

def enabled : Bool #

def enabled=(enabled : Bool) #

def excluded : Array(String) | Nil #

def excluded=(excluded : Array(String) | Nil) #

def filter_names : Array(String) #

def filter_names=(filter_names : Array(String)) #

def severity : Ameba::Severity #

def severity=(severity : Ameba::Severity) #

def test(source, node : Crystal::Call) #

[View source]
def test(source) #

[View source]