class Ameba::Rule::Style::NegatedConditionsInUnless

Overview

A rule that disallows negated conditions in unless.

For example, this is considered invalid:

unless !s.empty?
  :ok
end

And should be rewritten to the following:

if s.empty?
  :ok
end

It is pretty difficult to wrap your head around a block of code that is executed if a negated condition is NOT met.

YAML configuration example:

Style/NegatedConditionsInUnless:
  Enabled: true

Included Modules

Defined in:

ameba/rule/style/negated_conditions_in_unless.cr

Constant Summary

MSG = "Avoid negated conditions in unless blocks"

Constructors

Class Method Summary

Instance Method Summary

Instance methods inherited from class Ameba::Rule::Base

==(other) ==, catch(source : Source) catch, excluded?(source) excluded?, group group, hash hash, name name, special? special?, test(source : Source, node : Crystal::ASTNode, *opts)
test(source : Source) test

Class methods inherited from class Ameba::Rule::Base

default_severity : Ameba::Severity default_severity

Macros inherited from class Ameba::Rule::Base

issue_for(*args, **kwargs, &block) issue_for

Macros inherited from module Ameba::Config::RuleConfig

properties(&block) properties

Constructor Detail

def self.new(ctx : YAML::ParseContext, node : YAML::Nodes::Node) #

def self.new(config = nil) #

A rule that disallows negated conditions in unless.

For example, this is considered invalid:

unless !s.empty?
  :ok
end

And should be rewritten to the following:

if s.empty?
  :ok
end

It is pretty difficult to wrap your head around a block of code that is executed if a negated condition is NOT met.

YAML configuration example:

Style/NegatedConditionsInUnless:
  Enabled: true

[View source]

Class Method Detail

def self.parsed_doc : String | Nil #

Returns documentation for this rule, if there is any.

module Ameba
  # This is a test rule.
  # Does nothing.
  class MyRule < Ameba::Rule::Base
    def test(source)
    end
  end
end

MyRule.parsed_doc # => "This is a test rule.\nDoes nothing."

Instance Method Detail

def description : String #

def description=(description : String) #

def enabled=(enabled : Bool) #

def enabled? : Bool #

def excluded : Array(String) | Nil #

def excluded=(excluded : Array(String) | Nil) #

def severity : Ameba::Severity #

def severity=(severity : Ameba::Severity) #

def test(source, node : Crystal::Unless) #

[View source]